Identify wCurrentMapScriptFlags bits
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be my preference...I realize in a couple of cases they are set in the map script itself to re-trigger onLoad functions ( |
Rangi42
force-pushed
the
cur-map-script-flags
branch
from
22651e7
to
86a32a4
Compare
|
Sure, renamed |
|
can we do |
|
I'd prefer not to; that would seem to imply it's the bit for checking if a current map has loaded, when it's really one of a coequal pair. |
dannye
reviewed
Sep 24, 2024
dannye
reviewed
Sep 24, 2024
dannye
approved these changes
Sep 24, 2024
PokefanMarcel
pushed a commit
to PokefanMarcel/pokered
that referenced
this pull request
Oct 18, 2024
PokefanMarcel
added a commit
to PokefanMarcel/pokered
that referenced
this pull request
Oct 18, 2024
+ adapt own code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT_CUR_MAP_LOADED_1is the more frequently used flag, mostly used for updating map blocks (when you use a Card Key, press a switch, enter an Elite 4 room, etc).BIT_CUR_MAP_LOADED_2is mostly used for making Gyms load their statue sign names, and never re-set(with one exception in GameCorner.asm, which uses it to select a lucky slot machine, and re-sets it when the Rocket runs away).But since they're not exclusively for "changing blocks" and "loading Gym names", I didn't want to name the constants after those.